[oe-commits] [openembedded-core] 57/63: guile: fix a bashism

git at git.openembedded.org git at git.openembedded.org
Sat Mar 4 10:46:59 UTC 2017


This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit a2e6f288887f452d79427c985b6686d7f01f05a3
Author: Ming Liu <peter.x.liu at external.atlascopco.com>
AuthorDate: Fri Feb 24 12:57:31 2017 +0100

    guile: fix a bashism
    
    A following flaw was detected by verify-bashisms script:
    ......
    meta/recipes-devtools/guile/guile_2.0.13.bb
    possible bashism in guile_cross_config line 94 ($'...' should be "$(printf '...')"):
    
       echo '#!'`which ${BUILD_SYS}-guile`$' \\\n--no-auto-compile -e main -s\n!#\n(define %guile-build-info '\'\( \
           > ${B}/guile-config.cross
    ......
    
    Fixed by removing $'...' from echo command, using a printf instead.
    
    Signed-off-by: Ming Liu <peter.x.liu at external.atlascopco.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/recipes-devtools/guile/guile_2.0.14.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/guile/guile_2.0.14.bb b/meta/recipes-devtools/guile/guile_2.0.14.bb
index e0350e4..d2306e6 100644
--- a/meta/recipes-devtools/guile/guile_2.0.14.bb
+++ b/meta/recipes-devtools/guile/guile_2.0.14.bb
@@ -90,7 +90,7 @@ guile_cross_config() {
 	then
 	        # Create guile-config returning target values instead of native values
 	        install -d ${SYSROOT_DESTDIR}${STAGING_BINDIR_CROSS}
-        	echo '#!'`which ${BUILD_SYS}-guile`$' \\\n--no-auto-compile -e main -s\n!#\n(define %guile-build-info '\'\( \
+        	printf '#!%s \\\n--no-auto-compile -e main -s\n!#\n(define %%guile-build-info %s(\n' $(which ${BUILD_SYS}-guile) "'" \
 			> ${B}/guile-config.cross
 	        sed -n -e 's:^[ \t]*{[ \t]*":  (:' \
 			-e 's:",[ \t]*": . ":' \

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list