[oe-commits] [bitbake] 01/02: tinfoil: fix get_recipe_file() to return an error on invalid recipe

git at git.openembedded.org git at git.openembedded.org
Thu Mar 30 09:43:16 UTC 2017


This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository bitbake.

commit 54a4757ca706afc6e98c7692f960592e80cab12b
Author: Paul Eggleton <paul.eggleton at linux.intel.com>
AuthorDate: Thu Mar 30 15:23:59 2017 +1300

    tinfoil: fix get_recipe_file() to return an error on invalid recipe
    
    This function calls cooker.findBestProvider() but didn't handle the fact
    that that function returns a tuple (None, None, None, None) when there
    is no matching recipe. (This fixes devtool in OpenEmbedded showing a
    traceback when an invalid recipe is specified instead of a proper error
    message.)
    
    Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/tinfoil.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bb/tinfoil.py b/lib/bb/tinfoil.py
index c2ee707..14a2271 100644
--- a/lib/bb/tinfoil.py
+++ b/lib/bb/tinfoil.py
@@ -363,7 +363,7 @@ class Tinfoil:
         skipped.
         """
         best = self.find_best_provider(pn)
-        if not best:
+        if not best or (len(best) > 3 and not best[3]):
             skiplist = self.get_skipped_recipes()
             taskdata = bb.taskdata.TaskData(None, skiplist=skiplist)
             skipreasons = taskdata.get_reasons(pn)

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list