[oe-commits] [openembedded-core] 09/31: base.py: add assertExists and assertNotExists to oeselftest

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master
in repository openembedded-core.

commit b0a74554ef926ce05078494ca8e67178b56232f5
Author: Yeoh Ee Peng <ee.peng.yeoh at intel.com>
AuthorDate: Sun May 21 11:22:22 2017 -0700

    base.py: add assertExists and assertNotExists to oeselftest
    
    Current osselftest print confusing assertion message when using
    self.assertTrue(os.path.exists(filepath)) to test file path,
    example of confusing assertion message:
    	AssertionError: False is not true
    
    Add the assertExists and assertNotExists to improve assertion
    message and simplify coding, using selft.assertExists(filepath),
    will print meaningful assertion message:
    	AssertionError: <filepath> does not exist
    
    [YOCTO #11356]
    
    Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh at intel.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/lib/oeqa/selftest/base.py | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/meta/lib/oeqa/selftest/base.py b/meta/lib/oeqa/selftest/base.py
index 47a8ea8..43a1951 100644
--- a/meta/lib/oeqa/selftest/base.py
+++ b/meta/lib/oeqa/selftest/base.py
@@ -18,6 +18,7 @@ from oeqa.utils.commands import runCmd, bitbake, get_bb_var, get_test_layer
 from oeqa.utils.decorators import LogResults
 from random import choice
 import glob
+from unittest.util import safe_repr
 
 @LogResults
 class oeSelfTest(unittest.TestCase):
@@ -214,6 +215,18 @@ be re-executed from a clean environment to ensure accurate results.")
         self.log.debug("Writing to: %s\n%s\n" % (self.machineinc_path, data))
         ftools.write_file(self.machineinc_path, data)
 
+    # check does path exist    
+    def assertExists(self, expr, msg=None):
+        if not os.path.exists(expr):
+            msg = self._formatMessage(msg, "%s does not exist" % safe_repr(expr))
+            raise self.failureException(msg)
+    
+    # check does path not exist 
+    def assertNotExists(self, expr, msg=None):
+        if os.path.exists(expr):
+            msg = self._formatMessage(msg, "%s exists when it should not" % safe_repr(expr))
+            raise self.failureException(msg)
+
 
 def get_available_machines():
     # Get a list of all available machines

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.