[oe-commits] [openembedded-core] 26/44: recipetool: create: show a warning for github archive URLs

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 7e84a777aa924a237b4e604120ebf8a4b3ba53b2
Author: Paul Eggleton <paul.eggleton at linux.intel.com>
AuthorDate: Fri Oct 27 10:12:47 2017 +1300

    recipetool: create: show a warning for github archive URLs
    
    github archive URLs are not guaranteed to be stable [1] and thus we
    should show a warning if a user specifies one to recipetool create (or
    devtool add).
    
    [1] http://lists.openembedded.org/pipermail/openembedded-core/2017-September/142519.html
    
    Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 scripts/lib/recipetool/create.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/lib/recipetool/create.py b/scripts/lib/recipetool/create.py
index 055bdef..54e7e85 100644
--- a/scripts/lib/recipetool/create.py
+++ b/scripts/lib/recipetool/create.py
@@ -433,6 +433,9 @@ def create_recipe(args):
         source = 'file://%s' % os.path.abspath(source)
 
     if scriptutils.is_src_url(source):
+        # Warn about github archive URLs
+        if re.match('https?://github.com/[^/]+/[^/]+/archive/.+(\.tar\..*|\.zip)$', source):
+            logger.warn('github archive files are not guaranteed to be stable and may be re-generated over time. If the latter occurs, the checksums will likely change and the recipe will fail at do_fetch. It is recommended that you point to an actual commit or tag in the repository instead (using the repository URL in conjunction with the -S/--srcrev option).')
         # Fetch a URL
         fetchuri = reformat_git_uri(urldefrag(source)[0])
         if args.binary:

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.