[oe-commits] [openembedded-core] 14/21: cmake: fix typo in toolchain file

git at git.openembedded.org git at git.openembedded.org
Mon Oct 16 22:53:19 UTC 2017


This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master
in repository openembedded-core.

commit 03a4dd085e3be2821eff5a1a1e7e96b809465565
Author: Øystein Walle <ow at datarespons.no>
AuthorDate: Tue Oct 10 14:59:40 2017 +0200

    cmake: fix typo in toolchain file
    
    The missing underscore makes CMake define a new variable named "CMAKE"
    with the contents "ASM_FLAGS ${CMAKE_C_FLAGS}" instead of a variable
    named "CMAKE_ASM_FLAGS" with contents equal to "CMAKE_C_FLAGS". It seems
    clear that the intention was to assign "CMAKE_ASM_FLAGS".
    
    CMake uses variables named "CMAKE_<LANG>_FLAGS" for defining default
    compiler flags for a given language <LANG>. Leaving this flag unset may
    have unintended consequences. Not doing so is however not an error as
    far as CMake is concerned so it is silently accepted.
    
    Signed-off-by: Øystein Walle <ow at datarespons.no>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
index 6518408..dc8477e 100644
--- a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
+++ b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
@@ -1,7 +1,7 @@
 set( CMAKE_SYSTEM_NAME Linux )
 set( CMAKE_C_FLAGS $ENV{CFLAGS} CACHE STRING "" FORCE )
 set( CMAKE_CXX_FLAGS $ENV{CXXFLAGS}  CACHE STRING "" FORCE )
-set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
+set( CMAKE_ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
 set( CMAKE_LDFLAGS_FLAGS ${CMAKE_CXX_FLAGS} CACHE STRING "" FORCE )
 
 set( CMAKE_FIND_ROOT_PATH $ENV{OECORE_TARGET_SYSROOT} $ENV{OECORE_NATIVE_SYSROOT} )

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list