[oe-commits] [openembedded-core] 13/20: classes/reproducible_build: Avoid dereferencing symlinks
git at git.openembedded.org
git at git.openembedded.org
Tue Aug 7 12:29:44 UTC 2018
This is an automated email from the git hooks/post-receive script.
rpurdie pushed a commit to branch master-next
in repository openembedded-core.
commit cf32b1841622df29a55080f7085807cc37aa6842
Author: Joshua Watt <jpewhacker at gmail.com>
AuthorDate: Mon Aug 6 10:25:09 2018 -0500
classes/reproducible_build: Avoid dereferencing symlinks
Using os.path.getmtime() will dereference symbolic links in an attempt
to get the last modified time. This can cause errors if the target
doesn't exist, or worse map to some absolute build host path which would
make a build not reproducible.
Signed-off-by: Joshua Watt <JPEWhacker at gmail.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
meta/classes/reproducible_build.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes/reproducible_build.bbclass b/meta/classes/reproducible_build.bbclass
index 2df8053..268b5fb 100644
--- a/meta/classes/reproducible_build.bbclass
+++ b/meta/classes/reproducible_build.bbclass
@@ -56,7 +56,7 @@ def get_source_date_epoch_known_files(d, path):
for file in known_files:
filepath = os.path.join(path,file)
if os.path.isfile(filepath):
- mtime = int(os.path.getmtime(filepath))
+ mtime = int(os.lstat(filepath).st_mtime)
# There may be more than one "known_file" present, if so, use the youngest one
if mtime > source_date_epoch:
source_date_epoch = mtime
@@ -114,7 +114,7 @@ python do_create_source_date_epoch_stamp() {
for fname in files:
filename = os.path.join(root, fname)
try:
- mtime = int(os.path.getmtime(filename))
+ mtime = int(os.lstat(filename).st_mtime)
except ValueError:
mtime = 0
if mtime > source_date_epoch:
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the Openembedded-commits
mailing list