[oe-commits] [openembedded-core] 02/05: shadow: improve reproducibility by hard-coding shell path

git at git.openembedded.org git at git.openembedded.org
Wed Dec 5 22:35:56 UTC 2018


This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch sumo
in repository openembedded-core.

commit 83214b835cd82d5dddb47c418c4e7a20ac433f61
Author: Martin Hundebøll <martin at geanix.com>
AuthorDate: Thu Nov 15 10:12:48 2018 +0100

    shadow: improve reproducibility by hard-coding shell path
    
    The shadow configure script tries really hard to detect the running
    shell to make sure it doesn't do unsupported calls.
    
    On my system the shell is detected as /bin/sh, while a build in an
    ubuntu docker it resolves to /bin/bash. And since the shell path is
    baked into the target binaries through config.h, the build becomes
    inreproducible.
    
    Fix reproducibility by hard-coding the shell to be /bin/sh
    
    (From OE-Core rev: 5f4fe91cb6c21cd3ecd0b68d1c6b46a9530c7570)
    
    Signed-off-by: Martin Hundebøll <martin at geanix.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
    Signed-off-by: Armin Kuster <akuster808 at gmail.com>
---
 meta/recipes-extended/shadow/shadow.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/shadow/shadow.inc b/meta/recipes-extended/shadow/shadow.inc
index 9691c38..4e1eaed 100644
--- a/meta/recipes-extended/shadow/shadow.inc
+++ b/meta/recipes-extended/shadow/shadow.inc
@@ -53,6 +53,8 @@ PAM_SRC_URI = "file://pam.d/chfn \
 
 inherit autotools gettext
 
+export CONFIG_SHELL="/bin/sh"
+
 EXTRA_OECONF += "--without-audit \
                  --without-libcrack \
                  --without-selinux \

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list