[oe-commits] [openembedded-core] 08/17: systemd: remove the group 'lock'

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch rocko
in repository openembedded-core.

commit 1776ab75b8e5f00e69b99565af4cfeef27bc95d4
Author: Hannu Lounento <hannu.lounento at vaisala.com>
AuthorDate: Fri May 25 06:50:24 2018 +0000

    systemd: remove the group 'lock'
    
    The upstream commit 61f32bff6130a44d077886d38cff89ad161bf177 included in
    the release v229 removed the use of the group:
    
        commit 61f32bff6130a44d077886d38cff89ad161bf177
        Author: Martin Pitt <martin.pitt at ubuntu.com>
        Date:   Mon Feb 1 12:09:34 2016 +0100
    
            tmpfiles: drop /run/lock/lockdev
    
            Hardly any software uses that any more, and better locking mechanisms like
            flock() have been available for many years.
    
            Also drop the corresponding "lock" group from sysusers.d/basic.conf.in, as
            nothing else is using this.
    
        [...]
        diff --git a/sysusers.d/basic.conf.in b/sysusers.d/basic.conf.in
        index 823d6cb20..b2dc5ebd4 100644
        --- a/sysusers.d/basic.conf.in
        +++ b/sysusers.d/basic.conf.in
        @@ -19,7 +19,6 @@ g wheel   -     -            -
    
         # Access to certain kernel and userspace facilities
         g kmem    -     -            -
        -g lock    -     -            -
         g tty     @TTY_GID@     -            -
         g utmp    -     -            -
        [...]
    
    The upstream documentation doc/UIDS-GIDS.md says that basic.conf.in is "the
    precise list of the currently defined groups":
    
        ## Special `systemd` GIDs
    
        `systemd` defines no special UIDs beyond what Linux already defines (see
        above). However, it does define some special group/GID assignments, which are
        primarily used for `systemd-udevd`'s device management. The precise list of the
        currently defined groups is found in this `sysusers.d` snippet:
        [basic.conf](https://raw.githubusercontent.com/systemd/systemd/master/sysusers.d/basic.conf.in)
    
        It's strongly recommended that downstream distributions include these groups in
        their default group databases.
    
    Removing the creation of the group also avoids the need to define a GID
    for it when using static ids.
    
    (From OE-Core rev: da3659155cd1825a4a8d3d7c5288b4273714de15)
    
    Signed-off-by: Hannu Lounento <hannu.lounento at vaisala.com>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
    Signed-off-by: Armin Kuster <akuster808 at gmail.com>
---
 meta/recipes-core/systemd/systemd_234.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/systemd/systemd_234.bb b/meta/recipes-core/systemd/systemd_234.bb
index 9ce27bf..6c248e8 100644
--- a/meta/recipes-core/systemd/systemd_234.bb
+++ b/meta/recipes-core/systemd/systemd_234.bb
@@ -344,7 +344,7 @@ USERADD_PARAM_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'networkd', '--sys
 USERADD_PARAM_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'coredump', '--system -d / -M --shell /bin/nologin systemd-coredump;', '', d)}"
 USERADD_PARAM_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'resolved', '--system -d / -M --shell /bin/nologin systemd-resolve;', '', d)}"
 USERADD_PARAM_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'polkit', '--system --no-create-home --user-group --home-dir ${sysconfdir}/polkit-1 polkitd;', '', d)}"
-GROUPADD_PARAM_${PN} = "-r lock; -r systemd-journal"
+GROUPADD_PARAM_${PN} = "-r systemd-journal"
 USERADD_PARAM_${PN}-extra-utils += "--system -d / -M --shell /bin/nologin systemd-bus-proxy;"
 
 FILES_${PN}-analyze = "${bindir}/systemd-analyze"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.