[oe-commits] [openembedded-core] branch morty-next updated: lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch morty-next
in repository openembedded-core.

The following commit(s) were added to refs/heads/morty-next by this push:
     new 640d098  lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome
640d098 is described below

commit 640d098ef0dc6aec8780f951578163ed3e7df349
Author: Ming Liu <liu.ming50 at gmail.com>
AuthorDate: Mon Nov 20 10:35:57 2017 -0800

    lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome
    
    A flaw was found on my Ubuntu 14.04.5 LTS, on which that gnome-terminal is
    the default terminal, when I run any of the tasks:
    bitbake busybox -c menuconfig/devshell/devpyshell
    bitbake virtual/kernel -c menuconfig/devshell/devpyshell
    
    I got a error as follows:
    "Failed to execute child process "oe-gnome-terminal-phonehome" (No such file or directory)"
    
    Seems the environment of the process calling Popen is not passed to the
    child process, this behaviour is a known issue in Python bug tracker:
    http://bugs.python.org/issue8557
    
    It could be fixed by using an absolute path instead per test.
    
    Signed-off-by: Ming Liu <liu.ming50 at gmail.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
    (cherry picked from commit 2117c148ef07d84bc605768e3b3671b0126b9337)
    Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
    Signed-off-by: Armin Kuster <akuster808 at gmail.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/lib/oe/terminal.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
index 3c8ef59..65486bf 100644
--- a/meta/lib/oe/terminal.py
+++ b/meta/lib/oe/terminal.py
@@ -67,7 +67,7 @@ class Gnome(XTerminal):
         import tempfile
         pidfile = tempfile.NamedTemporaryFile(delete = False).name
         try:
-            sh_cmd = "oe-gnome-terminal-phonehome " + pidfile + " " + sh_cmd
+            sh_cmd = bb.utils.which(os.getenv('PATH'), "oe-gnome-terminal-phonehome") + " " + pidfile + " " + sh_cmd
             XTerminal.__init__(self, sh_cmd, title, env, d)
             while os.stat(pidfile).st_size <= 0:
                 continue
@@ -231,7 +231,6 @@ def spawn(name, sh_cmd, title=None, env=None, d=None):
         output = output.decode("utf-8")
     if pipe.returncode != 0:
         raise ExecutionError(sh_cmd, pipe.returncode, output)
-
 def check_tmux_pane_size(tmux):
     import subprocess as sub
     # On older tmux versions (<1.9), return false. The reason

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.