[oe-commits] [openembedded-core] 25/48: shadow: improve reproducibility by hard-coding shell path

git at git.openembedded.org git at git.openembedded.org
Thu Nov 8 22:21:56 UTC 2018


This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit da65a1c6dc4f6be2ec4c07ba8457e433fc41572f
Author: Martin Hundebøll <martin at geanix.com>
AuthorDate: Wed Nov 7 13:22:22 2018 +0100

    shadow: improve reproducibility by hard-coding shell path
    
    The shadow configure script tries really hard to detect the running
    shell to make sure it doesn't do unsupported calls.
    
    On my system the shell is detected as /bin/sh, while a build in an
    ubuntu docker it resolves to /bin/bash. And since the shell path is
    baked into the target binaries through config.h, the build becomes
    inreproducible.
    
    Fix reproducibility by hard-coding the shell to be /bin/sh
    
    Signed-off-by: Martin Hundebøll <martin at geanix.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/recipes-extended/shadow/shadow.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/shadow/shadow.inc b/meta/recipes-extended/shadow/shadow.inc
index 0fa80a2..09c37ef 100644
--- a/meta/recipes-extended/shadow/shadow.inc
+++ b/meta/recipes-extended/shadow/shadow.inc
@@ -45,6 +45,8 @@ PAM_SRC_URI = "file://pam.d/chfn \
 
 inherit autotools gettext
 
+export CONFIG_SHELL="/bin/sh"
+
 EXTRA_OECONF += "--without-audit \
                  --without-libcrack \
                  --without-selinux \

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list