[oe-commits] [openembedded-core] 11/26: image-buildinfo, oeqa/selftest/containerimage: Ensure image-buildinfo doesn't break tests

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit a2d78cc3304b7e3b05c1588bfc4a7c2bf1882df1
Author: Richard Purdie <richard.purdie at linuxfoundation.org>
AuthorDate: Fri Nov 9 11:24:47 2018 +0000

    image-buildinfo,oeqa/selftest/containerimage: Ensure image-buildinfo doesn't break tests
    
    Having image-buildinfo enabled causes containerimage.ContainerImageTests.test_expected_files
    to fail due to the presence of an unexpected file:
      ['./',
       './etc/',
    -  './etc/build',
       './etc/default/',
       './etc/default/postinst',
    
    Tweak the class to allow it to be disabled and disable it from the test just in
    case it was enabled.
    
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/classes/image-buildinfo.bbclass           | 2 ++
 meta/lib/oeqa/selftest/cases/containerimage.py | 1 +
 2 files changed, 3 insertions(+)

diff --git a/meta/classes/image-buildinfo.bbclass b/meta/classes/image-buildinfo.bbclass
index 213fb9c..87a6a1a 100644
--- a/meta/classes/image-buildinfo.bbclass
+++ b/meta/classes/image-buildinfo.bbclass
@@ -64,6 +64,8 @@ def buildinfo_target(d):
 
 # Write build information to target filesystem
 python buildinfo () {
+    if not d.getVar('IMAGE_BUILDINFO_FILE'):
+        return
     with open(d.expand('${IMAGE_ROOTFS}${IMAGE_BUILDINFO_FILE}'), 'w') as build:
         build.writelines((
             '''-----------------------
diff --git a/meta/lib/oeqa/selftest/cases/containerimage.py b/meta/lib/oeqa/selftest/cases/containerimage.py
index 99a5cc9..8deaae7 100644
--- a/meta/lib/oeqa/selftest/cases/containerimage.py
+++ b/meta/lib/oeqa/selftest/cases/containerimage.py
@@ -39,6 +39,7 @@ class ContainerImageTests(OESelftestTestCase):
 IMAGE_FSTYPES = "container"
 PACKAGE_CLASSES = "package_ipk"
 IMAGE_FEATURES = ""
+IMAGE_BUILDINFO_FILE = ""
 """)
 
         bbvars = get_bb_vars(['bindir', 'sysconfdir', 'localstatedir',

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.