[oe-commits] [bitbake] 07/11: toaster: disable git remote check to allow for firewalls

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository bitbake.

commit ab24e0ff2336c7fa95f3b0e845496f3aff78da87
Author: David Reyna <David.Reyna at windriver.com>
AuthorDate: Mon Oct 1 00:45:57 2018 -0700

    toaster: disable git remote check to allow for firewalls
    
    Toaster users behind firewalls that block "git" access usually
    require developers to add remap rules in their "~/.gitconfig"
    to remap GIT accesses to HTTP* access. However, there is a
    "git remote" test in Toaster that is not aware of such remaps,
    resulting in a false error.
    
    For now, disable this nice-to-have check to support this release,
    and re-enable when we can add remapping accommodations for this
    test.
    
    [YOCTO #12944]
    
    Signed-off-by: David Reyna <David.Reyna at windriver.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/toaster/bldcontrol/localhostbecontroller.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/toaster/bldcontrol/localhostbecontroller.py b/lib/toaster/bldcontrol/localhostbecontroller.py
index 67bfbf6..9490635 100644
--- a/lib/toaster/bldcontrol/localhostbecontroller.py
+++ b/lib/toaster/bldcontrol/localhostbecontroller.py
@@ -177,8 +177,11 @@ class LocalhostBEController(BuildEnvironmentController):
                 try:
                     localremotes = self._shellcmd("git remote -v",
                                                   localdirname,env=git_env)
-                    if not giturl in localremotes and commit != 'HEAD':
-                        raise BuildSetupException("Existing git repository at %s, but with different remotes ('%s', expected '%s'). Toaster will not continue out of fear of damaging something." % (localdirname, ", ".join(localremotes.split("\n")), giturl))
+                    # NOTE: this nice-to-have check breaks when using git remaping to get past firewall
+                    #       Re-enable later with .gitconfig remapping checks
+                    #if not giturl in localremotes and commit != 'HEAD':
+                    #    raise BuildSetupException("Existing git repository at %s, but with different remotes ('%s', expected '%s'). Toaster will not continue out of fear of damaging something." % (localdirname, ", ".join(localremotes.split("\n")), giturl))
+                    pass
                 except ShellCmdException:
                     # our localdirname might not be a git repository
                     #- that's fine

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.