[oe-commits] [openembedded-core] 13/18: gcc: Remove unnecessary --with-mpfr and --with-mpc when cross compiling

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit cd132e8376211554dd9e51dd7ed7cef61270a23b
Author: Mike Crowe <mac at mcrowe.com>
AuthorDate: Fri Oct 5 14:49:13 2018 +0100

    gcc: Remove unnecessary --with-mpfr and --with-mpc when cross compiling
    
    Passing --with-mpfr and --with-mpc when compiling the cross compiler
    appears to be at best unnecessary, and at worst can cause build failures.
    
    Firstly, the paths passed in gcc-cross-canadian are using the undefined
    ${layout_exec_prefix}. This results in configure passing
    -I${STAGING_DIR_HOST}/include twice to the compiler when it's doing its
    test builds. This is mostly pointless since that directory doesn't exist
    with the default oe-core configuration - the correct path would be
    -I${STAGING_DIR_HOST}/usr/include.
    
    The path for mpfr passed in gcc-cross is correct, but unnecessary since it
    is just the sysroot default.
    
    I've gone back through the history, and it seems that these lines (or
    similar ones) were originally added way back in
    8800d8be25295dd7c7d84dde62c3be4df8e43346 for GCC 4.1.1 in 2006! I asked[1]
    if anyone knew why this was necessary but received no response, so I can
    only assume that no-one knows.
    
    I've successfully built for various targets with this patch applied and
    observed no problems.
    
    [1] http://lists.openembedded.org/pipermail/openembedded-core/2018-September/155971.html
    
    Signed-off-by: Mike Crowe <mac at mcrowe.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/recipes-devtools/gcc/gcc-cross-canadian.inc | 5 -----
 meta/recipes-devtools/gcc/gcc-cross.inc          | 1 -
 2 files changed, 6 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
index bdd6f7e..2f32d34 100644
--- a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
+++ b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
@@ -160,11 +160,6 @@ SYSTEMLIBS1 = "${target_libdir}/"
 
 EXTRA_OECONF += "--enable-poison-system-directories"
 
-EXTRA_OECONF += "\
-    --with-mpfr=${STAGING_DIR_HOST}${layout_exec_prefix} \
-    --with-mpc=${STAGING_DIR_HOST}${layout_exec_prefix} \
-"
-
 EXTRA_OECONF_append_libc-baremetal = " --without-headers"
 EXTRA_OECONF_remove_libc-baremetal = "--with-sysroot=/not/exist"
 EXTRA_OECONF_remove_libc-baremetal = "--with-build-sysroot=${STAGING_DIR_TARGET}"
diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc
index 95f5968..89b1968 100644
--- a/meta/recipes-devtools/gcc/gcc-cross.inc
+++ b/meta/recipes-devtools/gcc/gcc-cross.inc
@@ -28,7 +28,6 @@ EXTRA_OECONF_append_sh4 = " \
 "
 
 EXTRA_OECONF += "\
-    --with-mpfr=${STAGING_DIR_NATIVE}${prefix_native} \
     --with-system-zlib \
 "
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.