[oe-commits] [openembedded-core] 06/12: cml1.bbclass: Use POSIX sh instead of var-SHELL

git at git.openembedded.org git at git.openembedded.org
Wed Apr 3 13:51:15 UTC 2019


This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master
in repository openembedded-core.

commit 50d3ec1ac994fb5968d8edf82823a7e3d1d67d21
Author: Nathan Rossi <nathan at nathanrossi.com>
AuthorDate: Tue Apr 2 08:17:39 2019 +0000

    cml1.bbclass: Use POSIX sh instead of var-SHELL
    
    Use the default POSIX sh instead of relying of var-SHELL being set to a
    compatible shell. Such that in cases where SHELL is set to a
    incompatible shell (e.g. csh, zsh, fish, etc.) the terminal command does
    not just silently fail.
    
    Signed-off-by: Nathan Rossi <nathan at nathanrossi.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/classes/cml1.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index 7f6df40..98d24ce 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -26,7 +26,7 @@ python do_menuconfig() {
     except OSError:
         mtime = 0
 
-    oe_terminal("${SHELL} -c \"make %s; if [ \\$? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"" % d.getVar('KCONFIG_CONFIG_COMMAND'),
+    oe_terminal("sh -c \"make %s; if [ \\$? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"" % d.getVar('KCONFIG_CONFIG_COMMAND'),
                 d.getVar('PN') + ' Configuration', d)
 
     # FIXME this check can be removed when the minimum bitbake version has been bumped

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list