[oe-commits] [openembedded-core] 02/04: runqemu: do not check return code of tput

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch warrior-next
in repository openembedded-core.

commit eb54c25c5ad4a8d8d47040e68e0ae7b93af19753
Author: Chen Qi <Qi.Chen at windriver.com>
AuthorDate: Fri Apr 12 09:40:06 2019 +0800

    runqemu: do not check return code of tput
    
    The subprocess.run was replaced by subprocess.check_call because
    of compatibility support down to python 3.4. But we really don't
    care about whether that command succeeds. Some user reports that
    in some tmux environment, this command fails and gives some
    unpleasant traceback output. So we use 'call' instead of 'check_call'
    to avoid such problem.
    
    Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 scripts/runqemu | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index c0e569c..a4fc606 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -1329,7 +1329,8 @@ def main():
             logger.info("SIGTERM received")
             os.kill(config.qemupid, signal.SIGTERM)
             config.cleanup()
-            subprocess.check_call(["tput", "smam"])
+            # Deliberately ignore the return code of 'tput smam'.
+            subprocess.call(["tput", "smam"])
         signal.signal(signal.SIGTERM, sigterm_handler)
 
         config.check_args()
@@ -1351,7 +1352,8 @@ def main():
         return 1
     finally:
         config.cleanup()
-        subprocess.check_call(["tput", "smam"])
+        # Deliberately ignore the return code of 'tput smam'.
+        subprocess.call(["tput", "smam"])
 
 if __name__ == "__main__":
     sys.exit(main())

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.