[oe-commits] [bitbake] 02/02: cooker.py: remove generation of recipe-depends.dot

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository bitbake.

commit ce033a2025cbe6cb92900c4c1cccb9926b4069b5
Author: Chen Qi <Qi.Chen at windriver.com>
AuthorDate: Thu Aug 22 15:52:51 2019 +0800

    cooker.py: remove generation of recipe-depends.dot
    
    The information of recipe-depends.dot is misleading.
    
    e.g.
    $ grep xz recipe-depends.dot | grep bzip2
    "bzip2" -> "xz"
    "xz" -> "bzip2"
    
    Users would wonder why they get some circular dependency.
    
    The information is derived from removing the task names
    of task-depends.dot. It's not giving people any additonal
    information, and it's misleading.
    
    So we remove the generation of this file.
    
    Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/cooker.py | 25 ++++---------------------
 1 file changed, 4 insertions(+), 21 deletions(-)

diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py
index 0607fcc..e46868d 100644
--- a/lib/bb/cooker.py
+++ b/lib/bb/cooker.py
@@ -919,6 +919,10 @@ class BBCooker:
             os.unlink('package-depends.dot')
         except FileNotFoundError:
             pass
+        try:
+            os.unlink('recipe-depends.dot')
+        except FileNotFoundError:
+            pass
 
         with open('task-depends.dot', 'w') as f:
             f.write("digraph depends {\n")
@@ -932,27 +936,6 @@ class BBCooker:
             f.write("}\n")
         logger.info("Task dependencies saved to 'task-depends.dot'")
 
-        with open('recipe-depends.dot', 'w') as f:
-            f.write("digraph depends {\n")
-            pndeps = {}
-            for task in sorted(depgraph["tdepends"]):
-                (pn, taskname) = task.rsplit(".", 1)
-                if pn not in pndeps:
-                    pndeps[pn] = set()
-                for dep in sorted(depgraph["tdepends"][task]):
-                    (deppn, deptaskname) = dep.rsplit(".", 1)
-                    pndeps[pn].add(deppn)
-            for pn in sorted(pndeps):
-                fn = depgraph["pn"][pn]["filename"]
-                version = depgraph["pn"][pn]["version"]
-                f.write('"%s" [label="%s\\n%s\\n%s"]\n' % (pn, pn, version, fn))
-                for dep in sorted(pndeps[pn]):
-                    if dep == pn:
-                        continue
-                    f.write('"%s" -> "%s"\n' % (pn, dep))
-            f.write("}\n")
-        logger.info("Flattened recipe dependencies saved to 'recipe-depends.dot'")
-
     def show_appends_with_no_recipes(self):
         # Determine which bbappends haven't been applied
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.