[oe-commits] [meta-openembedded] 01/01: libgpiod: Enable python3 in default packageconfig

git at git.openembedded.org git at git.openembedded.org
Wed Aug 28 01:30:05 UTC 2019


This is an automated email from the git hooks/post-receive script.

khem pushed a commit to branch master-next
in repository meta-openembedded.

commit cf23b0b8794e7fb88a99d727c39ae263433ca590
Author: Khem Raj <raj.khem at gmail.com>
AuthorDate: Tue Aug 27 18:05:37 2019 -0700

    libgpiod: Enable python3 in default packageconfig
    
    this recipe inherits python3native class conditionally, this condition
    depends on a given packageconfig, however inherit ${VAR} syntax requires
    VAR to be evaluated before inheriting it, therefore if someone appends
    python3 to packageconfig via a bbappend, then the packageconfig will
    become effective and add --enable-bindings-python to configure but
    inherit wont evaluate correctly since the expression adding to
    packageconfig
    
    PACKAGECONFIG_append = " python3"
    
    will be coming _after_ the inherit, and the builds will fail e.g.
    
    | ../../../libgpiod-1.3/bindings/python/gpiodmodule.c:8:10: fatal error: Python.h: No such file or directory
    |  #include <Python.h>
    
    This patch inverts the logic, meaning if someone has to disable python3
    bindings should write a bbappend e.g.
    
    PACKAGECONFIG_remove = "python3"
    
    This will still mean that python3native will be inherited but the
    effective configure option will be --disable-bindings-python and that
    will do the right thing
    
    See. https://github.com/openembedded/meta-openembedded/issues/140
    
    Signed-off-by: Khem Raj <raj.khem at gmail.com>
---
 meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb b/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb
index 756b143..ea1e491 100644
--- a/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb
+++ b/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb
@@ -6,7 +6,7 @@ SRC_URI[md5sum] = "585b4bb431f99c4ba9b3ee58b9d494c1"
 SRC_URI[sha256sum] = "21ae8fd1f8dafc2eb2ba50e652390cf533d21351419a7426255895cb52e21b1c"
 
 # enable tools and cxx bindings
-PACKAGECONFIG ?= "cxx tools"
+PACKAGECONFIG ?= "cxx tools python3"
 
 PACKAGECONFIG[cxx] = "--enable-bindings-cxx,--disable-bindings-cxx"
 PACKAGECONFIG[tests] = "--enable-tests,--disable-tests,kmod udev"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list