[oe-commits] [meta-openembedded] 01/15: libgpiod: nherit python3native unconditionally

git at git.openembedded.org git at git.openembedded.org
Wed Aug 28 14:16:37 UTC 2019


This is an automated email from the git hooks/post-receive script.

khem pushed a commit to branch master-next
in repository meta-openembedded.

commit 98625eb6c501d74d18e728a8b34e9719c7011f1b
Author: Khem Raj <raj.khem at gmail.com>
AuthorDate: Tue Aug 27 18:05:37 2019 -0700

    libgpiod: nherit python3native unconditionally
    
    this recipe inherits python3native class conditionally, this condition
    depends on a given packageconfig, however inherit ${VAR} syntax requires
    VAR to be evaluated before inheriting it, therefore if someone appends
    python3 to packageconfig via a bbappend, then the packageconfig will
    become effective and add --enable-bindings-python to configure but
    inherit wont evaluate correctly since the expression adding to
    packageconfig
    
    PACKAGECONFIG_append = " python3"
    
    will be coming _after_ the inherit, and the builds will fail e.g.
    
    | ../../../libgpiod-1.3/bindings/python/gpiodmodule.c:8:10: fatal error: Python.h: No such file or directory
    |  #include <Python.h>
    
    This will still mean that python3native is always inherited but the
    effective configure option will be --disable-bindings-python and that
    will do the right thing
    
    See. https://github.com/openembedded/meta-openembedded/issues/140
    
    Signed-off-by: Khem Raj <raj.khem at gmail.com>
---
 meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb b/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb
index 756b143..d559028 100644
--- a/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb
+++ b/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb
@@ -12,7 +12,8 @@ PACKAGECONFIG[cxx] = "--enable-bindings-cxx,--disable-bindings-cxx"
 PACKAGECONFIG[tests] = "--enable-tests,--disable-tests,kmod udev"
 
 PACKAGECONFIG[python3] = "--enable-bindings-python,--disable-bindings-python,python3"
-inherit ${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3native', '', d)}
+
+inherit python3native
 
 PACKAGES =+ "${PN}-python"
 FILES_${PN}-python = "${PYTHON_SITEPACKAGES_DIR}"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list