[oe-commits] [bitbake] branch 1.40 updated: siggen: Adapt colors used by bitbake-diffsigs to support light themes

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch 1.40
in repository bitbake.

The following commit(s) were added to refs/heads/1.40 by this push:
     new 3576941  siggen: Adapt colors used by bitbake-diffsigs to support light themes
3576941 is described below

commit 35769412de6387f55e5efa4ebc59a8d1e3c8870f
Author: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
AuthorDate: Sat Dec 22 23:16:21 2018 +0100

    siggen: Adapt colors used by bitbake-diffsigs to support light themes
    
    The colors specified for use with bitbake-diffsigs were adapted for a
    dark theme, e.g., by setting the background color to black, which made
    it look very bad when used with a light theme.
    
    To make it look good both with a dark or a light theme, it is better
    to drop the background color. It is also better to leave out the color
    altogether for the title and just use bold. Finally, dropping bold for
    the red and green texts indicating removed/added values better matches
    other colorized diff implementations as, e.g., git diff.
    
    Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/siggen.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index c619b59..fdbb2a3 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -342,10 +342,10 @@ def dump_this_task(outfile, d):
 def init_colors(enable_color):
     """Initialise colour dict for passing to compare_sigfiles()"""
     # First set up the colours
-    colors = {'color_title':   '\033[1;37;40m',
-              'color_default': '\033[0;37;40m',
-              'color_add':     '\033[1;32;40m',
-              'color_remove':  '\033[1;31;40m',
+    colors = {'color_title':   '\033[1m',
+              'color_default': '\033[0m',
+              'color_add':     '\033[0;32m',
+              'color_remove':  '\033[0;31m',
              }
     # Leave all keys present but clear the values
     if not enable_color:

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.