[oe-commits] [openembedded-core] 32/40: sdk: Fix SDKIMAGE_LINGUAS handling

git at git.openembedded.org git at git.openembedded.org
Fri Jan 11 10:40:29 UTC 2019


This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master
in repository openembedded-core.

commit 475a5d9ec21a329be973691734f9e8bcb332338c
Author: Richard Weinberger <richard at nod.at>
AuthorDate: Wed Jan 9 21:42:19 2019 +0100

    sdk: Fix SDKIMAGE_LINGUAS handling
    
    Currently SDKIMAGE_LINGUAS is broken for any inputs except "all".
    In the non-"all" case, each enabled language package is installed via
    pm.install("nativesdk-glibc-binary-localedata-%s.utf-8" % lang)
    This will throw a python exception since pm.install() expects a list of
    strings and not a string.
    
    Fix the problem by constructing a list.
    That way it is now also possible to call the package installer just
    once.
    
    Cc: "Burton, Ross" <ross.burton at intel.com>
    Fixes: 67615e01751b ("rootfs_rpm.bbclass: migrate image creation to dnf")
    Signed-off-by: Richard Weinberger <richard at nod.at>
    Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/lib/oe/sdk.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/lib/oe/sdk.py b/meta/lib/oe/sdk.py
index 153b07d..878ee16 100644
--- a/meta/lib/oe/sdk.py
+++ b/meta/lib/oe/sdk.py
@@ -95,8 +95,8 @@ class Sdk(object, metaclass=ABCMeta):
             if linguas == "all":
                 pm.install_glob("nativesdk-glibc-binary-localedata-*.utf-8", sdk=True)
             else:
-                for lang in linguas.split():
-                    pm.install("nativesdk-glibc-binary-localedata-%s.utf-8" % lang)
+                pm.install(["nativesdk-glibc-binary-localedata-%s.utf-8" % \
+                           lang for lang in linguas.split()])
             # Generate a locale archive of them
             target_arch = self.d.getVar('SDK_ARCH')
             rootfs = oe.path.join(self.sdk_host_sysroot, self.sdk_native_path)

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list