[oe-commits] [openembedded-core] 05/68: icecc: Syntax error meant that we weren't waiting for tarball generation

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch thud-next
in repository openembedded-core.

commit d4ec47005d29e30b31bc61fe126b385e9e781228
Author: Douglas Royds <douglas.royds at taitradio.com>
AuthorDate: Thu Dec 20 11:59:46 2018 +1300

    icecc: Syntax error meant that we weren't waiting for tarball generation
    
    If two bitbake processes try to generate the ICECC_VERSION tarball at the same
    time, the thread that fails to get the lock will wait 30 sec for the first to
    finish. A syntax error meant that this was not happening, and in particular, if
    tarball generation failed (eg. for lack of patchelf), it did so silently.
    
    (From OE-Core rev: 4455c46bf7f49c2b44f250aa89b63b342368e2e3)
    
    Signed-off-by: Douglas Royds <douglas.royds at taitradio.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
    Signed-off-by: Armin Kuster <akuster808 at gmail.com>
---
 meta/classes/icecc.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
index d8a7894..2171e11 100644
--- a/meta/classes/icecc.bbclass
+++ b/meta/classes/icecc.bbclass
@@ -387,7 +387,7 @@ set_icecc_env() {
             ${ICECC_ENV_EXEC} ${ICECC_ENV_DEBUG} "${ICECC_CC}" "${ICECC_CXX}" "${ICECC_AS}" "${ICECC_VERSION}"
         then
             touch "${ICECC_VERSION}.done"
-        elif [ ! wait_for_file "${ICECC_VERSION}.done" 30 ]
+        elif ! wait_for_file "${ICECC_VERSION}.done" 30 
         then
             # locking failed so wait for ${ICECC_VERSION}.done to appear
             bbwarn "Timeout waiting for ${ICECC_VERSION}.done"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.