[oe-commits] [bitbake] 01/02: build: Ensure warning for invalid task dependencies is useful

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master
in repository bitbake.

commit e034c6f75e3d7730ff16a8d1bd0cba03beda0af8
Author: Richard Purdie <richard.purdie at linuxfoundation.org>
AuthorDate: Wed May 1 11:54:27 2019 +0100

    build: Ensure warning for invalid task dependencies is useful
    
    WARNING: elfutils: dependent task do_rm_work does not exist
    
    is much less useful than
    
    WARNING: elfutils: dependent task do_rm_work for do_deploy does not exist
    
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/build.py       | 2 +-
 lib/bb/tests/parse.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/bb/build.py b/lib/bb/build.py
index da592e6..8ad9f5d 100644
--- a/lib/bb/build.py
+++ b/lib/bb/build.py
@@ -819,7 +819,7 @@ def add_tasks(tasklist, d):
             for dep in flags['deps']:
                 # Check and warn for "addtask task after foo" while foo does not exist
                 if not dep in tasklist:
-                    bb.warn('%s: dependent task %s does not exist' % (d.getVar('PN'), dep))
+                    bb.warn('%s: dependent task %s for %s does not exist' % (d.getVar('PN'), dep, task))
                 dep = d.expand(dep)
                 task_deps['parents'][task].append(dep)
 
diff --git a/lib/bb/tests/parse.py b/lib/bb/tests/parse.py
index 4467d17..aa7adc4 100644
--- a/lib/bb/tests/parse.py
+++ b/lib/bb/tests/parse.py
@@ -203,5 +203,5 @@ deltask do_fetch do_patch
         self.assertTrue("addtask contained multiple 'after' keywords" in stdout)
         self.assertTrue('addtask ignored: " do_patch"' in stdout)
         self.assertTrue('deltask ignored: " do_patch"' in stdout)
-        self.assertTrue('dependent task do_foo does not exist' in stdout)
+        self.assertTrue('dependent task do_foo for do_patch does not exist' in stdout)
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.