[oe-commits] [openembedded-core] 42/66: runqemu: do not check return code of tput

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch thud
in repository openembedded-core.

commit ced3c75fa75d9b9373d695d9204b197b98ea3bd9
Author: Chen Qi <Qi.Chen at windriver.com>
AuthorDate: Fri Apr 12 09:40:06 2019 +0800

    runqemu: do not check return code of tput
    
    The subprocess.run was replaced by subprocess.check_call because
    of compatibility support down to python 3.4. But we really don't
    care about whether that command succeeds. Some user reports that
    in some tmux environment, this command fails and gives some
    unpleasant traceback output. So we use 'call' instead of 'check_call'
    to avoid such problem.
    
    Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
    Signed-off-by: Armin Kuster <akuster808 at gmail.com>
---
 scripts/runqemu | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index 1c96b29..f83e057 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -1333,7 +1333,8 @@ def main():
             logger.info("SIGTERM received")
             os.kill(config.qemupid, signal.SIGTERM)
             config.cleanup()
-            subprocess.check_call(["tput", "smam"])
+            # Deliberately ignore the return code of 'tput smam'.
+            subprocess.call(["tput", "smam"])
         signal.signal(signal.SIGTERM, sigterm_handler)
 
         config.check_args()
@@ -1355,7 +1356,8 @@ def main():
         return 1
     finally:
         config.cleanup()
-        subprocess.check_call(["tput", "smam"])
+        # Deliberately ignore the return code of 'tput smam'.
+        subprocess.call(["tput", "smam"])
 
 if __name__ == "__main__":
     sys.exit(main())

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.