[oe-commits] [openembedded-core] 19/37: base-files: set ptmxmode to 666

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit b2b7615a1580646226fda9b1f46220dd297b66d2
Author: Stefan Agner <stefan.agner at toradex.com>
AuthorDate: Fri Nov 15 16:09:44 2019 +0000

    base-files: set ptmxmode to 666
    
    Make sure that the (newer) /dev/pts/ptmx is accessible by users. This
    is useful e.g. when running containers which symlink /dev/ptmx to
    /dev/pts/ptmx on start. The default mode (000) does not allow to
    create ptys inside the container.
    
    Using 666 when symlinking /dev/ptmx is also recommended by the kernel
    documentation when /dev/ptmx is symlinked:
    https://www.kernel.org/doc/Documentation/filesystems/devpts.txt
    
    Also buildroot uses ptmxmode=0666. The patch introducing the change
    explains related use cases why this is necessary a bit more in depth:
    https://github.com/buildroot/buildroot/commit/8196b299ba12bd6741bf7f4462cad180dab77fb0#diff-2d4604b9e565eb19fa52ce31f282f06c
    
    Signed-off-by: Stefan Agner <stefan.agner at toradex.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/recipes-core/base-files/base-files/fstab | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/base-files/base-files/fstab b/meta/recipes-core/base-files/base-files/fstab
index d79a016..70e400f 100644
--- a/meta/recipes-core/base-files/base-files/fstab
+++ b/meta/recipes-core/base-files/base-files/fstab
@@ -2,7 +2,7 @@
 
 /dev/root            /                    auto       defaults              1  1
 proc                 /proc                proc       defaults              0  0
-devpts               /dev/pts             devpts     mode=0620,gid=5       0  0
+devpts               /dev/pts             devpts     mode=0620,ptmxmode=0666,gid=5      0  0
 tmpfs                /run                 tmpfs      mode=0755,nodev,nosuid,strictatime 0  0
 tmpfs                /var/volatile        tmpfs      defaults              0  0
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.