[oe-commits] [openembedded-core] 11/11: lib/oe/terminal.py: fix gnome-terminal start behavior

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit 927ea4d34a715b442f78ac0cab785f6a673eb4cc
Author: Trevor Gamblin <trevor.gamblin at windriver.com>
AuthorDate: Thu Oct 3 18:45:43 2019 -0400

    lib/oe/terminal.py: fix gnome-terminal start behavior
    
    [Bugzilla Bug 13201] -- https://bugzilla.yoctoproject.org/show_bug.cgi?id=13201
    
    Newer versions of gnome-terminal (3.32.0 and up) are not starting
    as expected for commands e.g. "bitbake -c devshell zlib". This
    manifests as the instance appearing as a new tab rather than a
    new window. Fix this (and maintain new window preferred behavior)
    by changing the "-x" option to "--" as per the warning message,
    avoiding deprecated options:
    
        # Option “--command” is deprecated and might be removed in a later version of gnome-terminal.
        # Use “-- ” to terminate the options and put the command line to execute after it.
    
    Signed-off-by: Trevor Gamblin <trevor.gamblin at windriver.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/lib/oe/terminal.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
index 9bda3ef..a1daa2b 100644
--- a/meta/lib/oe/terminal.py
+++ b/meta/lib/oe/terminal.py
@@ -55,7 +55,7 @@ class XTerminal(Terminal):
             raise UnsupportedTerminal(self.name)
 
 class Gnome(XTerminal):
-    command = 'gnome-terminal -t "{title}" -x {command}'
+    command = 'gnome-terminal -t "{title}" -- {command}'
     priority = 2
 
     def __init__(self, sh_cmd, title=None, env=None, d=None):

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.