[oe-commits] [openembedded-core] 02/20: sanity: check the format of SDK_VENDOR

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master-next
in repository openembedded-core.

commit b0efd8d4d0dbc30e6505b42f5603f18fa764d732
Author: Ross Burton <ross.burton at intel.com>
AuthorDate: Mon Oct 14 12:42:57 2019 +0100

    sanity: check the format of SDK_VENDOR
    
    If SDK_VENDOR isn't formatted as -foosdk and is instead for example -foo-sdk
    then the triple that are constructed are not in fact triples, which results in
    mysterious compile errors.
    
    Check in sanity.bbclass so this failure is detected early.
    
    [ YOCTO #13573 ]
    
    Signed-off-by: Ross Burton <ross.burton at intel.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/classes/sanity.bbclass | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 2d3f49e..705062b 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -798,6 +798,11 @@ def check_sanity_everybuild(status, d):
         elif d.getVar('SDK_ARCH', False) == "${BUILD_ARCH}":
             status.addresult('SDKMACHINE is set, but SDK_ARCH has not been changed as a result - SDKMACHINE may have been set too late (e.g. in the distro configuration)\n')
 
+    # If SDK_VENDOR looks like "-my-sdk" then the triples are badly formed so fail early
+    sdkvendor = d.getVar("SDK_VENDOR")
+    if not (sdkvendor.startswith("-") and sdkvendor.count("-") == 1):
+        status.addresult("SDK_VENDOR should be of the form '-foosdk' with a single dash\n")
+
     check_supported_distro(d)
 
     omask = os.umask(0o022)

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.