[oe-commits] [openembedded-core] 06/06: qemu: Avoid potential build configuration contamination

git at git.openembedded.org git at git.openembedded.org
Mon Oct 28 05:32:36 UTC 2019


This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master
in repository openembedded-core.

commit b91b30c09ffbcd81e8dcaae832b3ae4f61046236
Author: Richard Purdie <richard.purdie at linuxfoundation.org>
AuthorDate: Sun Oct 27 10:11:54 2019 +0000

    qemu: Avoid potential build configuration contamination
    
    Changing the gl options to qemu doesn't result in a correctly rebuilt
    binary, the GL linkage can persist from a build where it was enabled
    to one where it was not.
    
    As well as clearly being incorrect and non-reproducible, this caused
    some mystery failures on the autobuilder.
    
    Cleaning ${B} at do_configure time avoids this. Most recipes
    (e.g. autotools derived ones) already clean ${B} as appropriate and
    avoid this issue.
    
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/recipes-devtools/qemu/qemu.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
index bb444b6..601fc22 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -95,6 +95,7 @@ do_configure_prepend_class-native() {
 do_configure() {
     ${S}/configure ${EXTRA_OECONF}
 }
+do_configure[cleandirs] += "${B}"
 
 do_install () {
 	export STRIP=""

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Openembedded-commits mailing list