[oe-commits] [openembedded-core] 10/17: oeqa/selftest: For toolchain tests do not fail if a test failed

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch master
in repository openembedded-core.

commit 073575ff9c06b2791cc2bd88063d815d2220f038
Author: Nathan Rossi <nathan at nathanrossi.com>
AuthorDate: Wed Sep 4 14:23:23 2019 +0000

    oeqa/selftest: For toolchain tests do not fail if a test failed
    
    Do not fail the running selftest test case if the test suite has a
    failed test case. Currently toolchain tests suites (binutils, gcc,
    glibc) fail but this does not indicate failure to execute the tests.
    
    Also remove the logging of each test that failed.
    
    Signed-off-by: Nathan Rossi <nathan at nathanrossi.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/lib/oeqa/selftest/cases/binutils.py | 6 ------
 meta/lib/oeqa/selftest/cases/gcc.py      | 6 ------
 meta/lib/oeqa/selftest/cases/glibc.py    | 5 -----
 3 files changed, 17 deletions(-)

diff --git a/meta/lib/oeqa/selftest/cases/binutils.py b/meta/lib/oeqa/selftest/cases/binutils.py
index 4edee09..7f88795 100644
--- a/meta/lib/oeqa/selftest/cases/binutils.py
+++ b/meta/lib/oeqa/selftest/cases/binutils.py
@@ -52,13 +52,7 @@ class BinutilsCrossSelfTest(OESelftestTestCase):
         if not os.path.exists(sumspath):
             sumspath = os.path.join(builddir, suite, "testsuite", "{0}.sum".format(suite))
 
-        failed = 0
         with open(sumspath, "r") as f:
             for test, result in parse_values(f):
                 self.tc.extraresults["ptestresult.{}.{}".format(ptestsuite, test)] = {"status" : result}
-                if result == "FAIL":
-                    self.logger.info("failed: '{}'".format(test))
-                    failed += 1
-
-        self.assertEqual(failed, 0)
 
diff --git a/meta/lib/oeqa/selftest/cases/gcc.py b/meta/lib/oeqa/selftest/cases/gcc.py
index 0b0157e..dba453f 100644
--- a/meta/lib/oeqa/selftest/cases/gcc.py
+++ b/meta/lib/oeqa/selftest/cases/gcc.py
@@ -71,7 +71,6 @@ class GccSelfTest(OESelftestTestCase):
         bb_vars = get_bb_vars(["B", "TARGET_SYS"], recipe)
         builddir, target_sys = bb_vars["B"], bb_vars["TARGET_SYS"]
 
-        failed = 0
         for suite in suites:
             sumspath = os.path.join(builddir, "gcc", "testsuite", suite, "{0}.sum".format(suite))
             if not os.path.exists(sumspath): # check in target dirs
@@ -84,11 +83,6 @@ class GccSelfTest(OESelftestTestCase):
             with open(sumspath, "r") as f:
                 for test, result in parse_values(f):
                     self.tc.extraresults["ptestresult.{}.{}".format(ptestsuite, test)] = {"status" : result}
-                    if result == "FAIL":
-                        self.logger.info("failed: '{}'".format(test))
-                        failed += 1
-
-        self.assertEqual(failed, 0)
 
 class GccSelfTestSystemEmulated(GccSelfTest):
     default_installed_packages = ["libgcc", "libstdc++", "libatomic", "libgomp"]
diff --git a/meta/lib/oeqa/selftest/cases/glibc.py b/meta/lib/oeqa/selftest/cases/glibc.py
index 6a34da3..7992ea6 100644
--- a/meta/lib/oeqa/selftest/cases/glibc.py
+++ b/meta/lib/oeqa/selftest/cases/glibc.py
@@ -43,15 +43,10 @@ class GlibcSelfTest(OESelftestTestCase):
 
         builddir = get_bb_var("B", "glibc-testsuite")
 
-        failed = 0
         self.tc.extraresults["ptestresult.sections"]["glibc"] = {}
         with open(os.path.join(builddir, "tests.sum"), "r") as f:
             for test, result in parse_values(f):
                 self.tc.extraresults["ptestresult.glibc.{}".format(test)] = {"status" : result}
-                if result == "FAIL":
-                    self.logger.info("failed: '{}'".format(test))
-                    failed += 1
-        self.assertEqual(failed, 0)
 
 class GlibcSelfTestSystemEmulated(GlibcSelfTest):
     default_installed_packages = [

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.