[oe-commits] [bitbake] 18/25: lib/bb: Optimise out debug messages from cooker

[git at git.openembedded.org]

This is an automated email from the git hooks/post-receive script.

rpurdie pushed a commit to branch 1.44
in repository bitbake.

commit f224201b5003b89367d688b1f08a062754fce13a
Author: Richard Purdie <richard.purdie at linuxfoundation.org>
AuthorDate: Sun Dec 15 17:45:20 2019 +0000

    lib/bb: Optimise out debug messages from cooker
    
    We have bb.debug(2, xxx) messages in cooker which are useful for debugging
    but have really bad effects on performance, 640,000 calls on recent profile
    graphs taking tens of seconds.
    
    Rather than commenting out debug which can be useful for debugging, don't
    create events for debug log messages from cooker which would never be seen.
    We already stop the messages hitting the IPC but this avoids the overhead
    of creating the log messages too, which has been shown to be signficiant
    on the profiles. This allows the code to perform whilst allowing debug
    messages to be availble when wanted/enabled.
    
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
    (cherry picked from commit f04cd931091fb0508badf3e002d70a6952700495)
---
 lib/bb/__init__.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/bb/__init__.py b/lib/bb/__init__.py
index c144311..ce519ba 100644
--- a/lib/bb/__init__.py
+++ b/lib/bb/__init__.py
@@ -43,6 +43,11 @@ class BBLogger(Logger):
         Logger.__init__(self, name)
 
     def bbdebug(self, level, msg, *args, **kwargs):
+        if not bb.event.worker_pid:
+            if self.name in bb.msg.loggerDefaultDomains and level > (bb.msg.loggerDefaultDomains[self.name]):
+                return
+            if level > (bb.msg.loggerDefaultDebugLevel):
+                return
         return self.log(logging.DEBUG - level + 1, msg, *args, **kwargs)
 
     def plain(self, msg, *args, **kwargs):

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.