[OE-core] [PATCH 28/46] xorg-lib: inherit gettext class instead of adding gettext to DEPENDS directly

[Richard Purdie]

On Thu, 2011-03-31 at 21:29 -0700, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  meta/recipes-graphics/xorg-lib/libxau_1.0.6.bb     |    2 +-
>  meta/recipes-graphics/xorg-lib/libxdmcp_1.1.0.bb   |    2 --
>  meta/recipes-graphics/xorg-lib/xorg-lib-common.inc |    2 +-
>  meta/recipes-graphics/xorg-lib/xtrans_1.2.6.bb     |    1 -
>  4 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/recipes-graphics/xorg-lib/libxau_1.0.6.bb b/meta/recipes-graphics/xorg-lib/libxau_1.0.6.bb
> index 79078ef..c96b6e9 100644
> --- a/meta/recipes-graphics/xorg-lib/libxau_1.0.6.bb
> +++ b/meta/recipes-graphics/xorg-lib/libxau_1.0.6.bb
> @@ -9,7 +9,7 @@ require xorg-lib-common.inc
>  LICENSE = "MIT-style"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=7908e342491198401321cec1956807ec"
>  
> -DEPENDS += " xproto gettext"
> +DEPENDS += " xproto"
>  PROVIDES = "xau"
>  
>  PR = "r0"
> diff --git a/meta/recipes-graphics/xorg-lib/libxdmcp_1.1.0.bb b/meta/recipes-graphics/xorg-lib/libxdmcp_1.1.0.bb
> index d897dab..8ac8e38 100644
> --- a/meta/recipes-graphics/xorg-lib/libxdmcp_1.1.0.bb
> +++ b/meta/recipes-graphics/xorg-lib/libxdmcp_1.1.0.bb
> @@ -17,8 +17,6 @@ PROVIDES = "xdmcp"
>  PR = "r0"
>  PE = "1"
>  
> -DEPENDS += "gettext"
> -
>  XORG_PN = "libXdmcp"
>  
>  BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc b/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
> index 4ed8c86..9b4ce1e 100644
> --- a/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
> +++ b/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
> @@ -11,6 +11,6 @@ SRC_URI = "${XORG_MIRROR}/individual/lib/${XORG_PN}-${PV}.tar.bz2"
>  
>  S = "${WORKDIR}/${XORG_PN}-${PV}"
>  
> -inherit autotools pkgconfig
> +inherit autotools pkgconfig gettext

NAK. Please don't add gettext dependencies to every xorg library because
three of them require it. Please add the inherits to the individual
recipes that need it. This improves parallel build performance as some
things can start compiling before gettext is built.

Cheers,

Richard