[OE-core] [RFC][PATCH] git: use DESTDIR=$D instead prefixing all variables by $D

Koen Kooi koen at dominion.thruhere.net
Tue Apr 26 11:55:15 UTC 2011


Op 18 apr 2011, om 14:44 heeft Martin Jansa het volgende geschreven:

> * with git-native and rm_work enabled I've noticed git fetcher errors like:
>  warning: templates not found /OE/shr-core/tmp/work/x86_64-linux/git-native-1.7.3.4-r0/image/OE/shr-core/tmp/sysroots/x86_64-linux/usr/share/git-core/templates
>  fatal: Unable to find remote helper for 'http'
>  for every recipe using http:// for git repo
> * after this change template_dir points to
>  /OE/shr-core/tmp/sysroots/x86_64-linux/usr/share/git-core/templates
>  without that workdir prefix
> * haven't tested target recipe, but I guess it needs different fix or
>  maybe it worked before and gets broken by this change (that's why this
>  is just RFC)


Can you send this as a proper patch that bumps PR? I'm getting really annoyed by this bug and I hope Saul will pick it up soon.

regards,

Koen

> 
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> ---
> meta/recipes-devtools/git/git.inc |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/git/git.inc b/meta/recipes-devtools/git/git.inc
> index e1d1c71..843a1d3 100644
> --- a/meta/recipes-devtools/git/git.inc
> +++ b/meta/recipes-devtools/git/git.inc
> @@ -14,8 +14,8 @@ EXTRA_OECONF = "--with-perl=${STAGING_BINDIR_NATIVE}/perl --without-tcltk"
> inherit autotools
> 
> do_install () {
> -	oe_runmake install prefix=${D} bindir=${D}${bindir} gitexecdir=${D}${gitexecdir} \
> -		template_dir=${D}${datadir}/git-core/templates \
> +	oe_runmake install DESTDIR="${D}" bindir=${bindir} gitexecdir=${gitexecdir} \
> +		template_dir=${datadir}/git-core/templates \
> 		GIT_PYTHON_DIR=${D}${datadir}/git-core/python
> }
> 
> -- 
> 1.7.5.rc1
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core





More information about the Openembedded-core mailing list