[OE-core] [PATCH v2] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case

Phil Blundell philb at gnu.org
Mon Aug 1 16:00:37 UTC 2011


On Mon, 2011-08-01 at 15:41 +0200, Koen Kooi wrote:
> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
> index ce9cee5..704f86b 100644
> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
> @@ -14,9 +14,9 @@ TUNE_FEATURES_tune-armv7a ?= "armv7a vfp"
>  TUNE_FEATURES_tune-armv7at ?= "armv7a vfp thumb"
>  TUNE_FEATURES_tune-armv7a-neon ?= "armv7a vfp neon"
>  TUNE_FEATURES_tune-armv7at-neon ?= "armv7a vfp neon thumb"
> -PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv7a = "${PACKAGE_EXTRA_ARCHS_tune-armv7} armv7a armv7a-vfp"
>  PACKAGE_EXTRA_ARCHS_tune-armv7a-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a} armv7a-vfp-neon"
> -PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a-vfp armv7at2-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a armv7a-vfp armv7at2-vfp"
>  PACKAGE_EXTRA_ARCHS_tune-armv7at-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at} armv7a-vfp-neon armv7at2-vfp-neon"

Shouldn't this be getting handled in pkgarch_mapping() at the point
where the renaming happens?  In this particular case it seems harmless
(if a bit fragile) to name both possibilities in PACKAGE_EXTRA_ARCHS_...
but I'm not certain that this will always be safe in general.

p.






More information about the Openembedded-core mailing list