[OE-core] [PATCH] libc-package bbclass: fix binary localedata dependency code
Phil Blundell
philb at gnu.org
Thu Aug 4 22:00:26 UTC 2011
On Wed, 2011-08-03 at 08:19 +0200, Koen Kooi wrote:
> Op 2 aug. 2011, om 17:01 heeft Phil Blundell het volgende geschreven:
>
> > It does look a bit weird. That code was introduced in 561d8754,
> > ostensibly as a merger of the eglibc and glibc equivalents. But, the
> > original code from glibc-package.bbclass did:
> >
> > def output_locale_binary_rdepends(name, pkgname, locale, encoding):
> > m = re.match("(.*)\.(.*)", name)
> > if m:
> > glibc_name = "%s.%s" % (m.group(1), m.group(2).lower().replace("-",""))
> > else:
> > glibc_name = name
> > bb.data.setVar('RDEPENDS_%s' % pkgname, legitimize_package_name('glibc-binary-localedata-%s' % glibc_name), d)
> >
> > ... i.e. it was using the "." separator both for splitting and joining,
> > which seems reasonable. But somehow when it showed up in
> > libc-package.bbclass it had gotten transmogrified so that it split on
> > "_" but joined with "." as you showed below. That seems bogus to me.
I'm not sure whether your original locale problem is still an issue, but
I am still fairly convinced that the change to the regex in the code
above was incorrect. Unless the author of 561d8754 wants to speak up in
its defence soon, I will submit a patch to change it back to using ".".
p.
More information about the Openembedded-core
mailing list