[OE-core] [PATCH 06/10] kernel, module-base.bbclass: fix KERNEL_LD & KERNEL_AR vars

Richard Purdie richard.purdie at linuxfoundation.org
Fri Aug 5 16:16:32 UTC 2011


On Fri, 2011-08-05 at 08:41 -0700, Kamble, Nitin A wrote:
> 
> > -----Original Message-----
> > From: openembedded-core-bounces at lists.openembedded.org
> > [mailto:openembedded-core-bounces at lists.openembedded.org] On Behalf Of
> > Phil Blundell
> > Sent: Friday, August 05, 2011 12:52 AM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 06/10] kernel, module-base.bbclass: fix
> > KERNEL_LD & KERNEL_AR vars
> > 
> > On Thu, 2011-08-04 at 15:03 -0700, Kamble, Nitin A wrote:
> > >
> > > > -----Original Message-----
> > > > From: openembedded-core-bounces at lists.openembedded.org
> > > > [mailto:openembedded-core-bounces at lists.openembedded.org] On Behalf
> > Of
> > > > Phil Blundell
> > > > Sent: Thursday, August 04, 2011 2:50 PM
> > > > To: Patches and discussions about the oe-core layer
> > > > Subject: Re: [OE-core] [PATCH 06/10] kernel, module-base.bbclass:
> > fix
> > > > KERNEL_LD & KERNEL_AR vars
> > > >
> > > > On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble at intel.com wrote:
> > > > > From: Nitin A Kamble <nitin.a.kamble at intel.com>
> > > > >
> > > > > KERNEL_LD was using ${LD} in it's definition, which is not
> > correct
> > > > for
> > > > > different ABIs such as x32 or i386 on x86_64 machine.
> > > > >
> > > > > Same with KERNEL_AR var.
> > > >
> > > > Why is ar an issue?  That doesn't have any unusual args, does it?
> > > >
> > > > p.
> > >
> > > No special args for ar, but The change makes definition of KERNEL_AR
> > consistent with other definitions like KERNEL_CC & KERNEL_LD.
> > 
> > Okay, fair enough.  Please say that in the checkin message, though.
> > The
> > existing text makes it sound as though KERNEL_AR was actually broken
> > before.
>  
> Point noted, Changed the commit message.

I've merged this with an updated commit message.

Cheers,

Richard





More information about the Openembedded-core mailing list