[OE-core] [PATCH 7/8] scripts/runqemu: remove redundant checking

[Phil Blundell]

On Sat, 2011-08-20 at 04:58 +0000, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> ---
>  scripts/runqemu |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 91c3c9e..d617f79 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -163,7 +163,7 @@ while [ $i -le $# ]; do
>              # A directory name is an nfs rootfs
>              if [ -d "$arg" ]; then
>                  echo "Assuming $arg is an nfs rootfs"
> -                if [[ -z "$FSTYPE" || "$FSTYPE" == "nfs" ]]; then
> +                if [[ -z "$FSTYPE" ]]; then
>                      FSTYPE=nfs
>                  else
>                      echo "Error: conflicting FSTYPE types [$arg] and nfs"

Can you explain why this test is redundant?  From inspection of the
patch it seems this would lead to "Error: conflicting FSTYPE types [nfs]
and nfs" if FSTYPE="nfs" to begin with.  I guess there is some other
provision in the logic to make sure that this can't happen, but it would
be useful to have it explained in the checkin message.

p.