[OE-core] [PATCH] utils.bbclass: skip empty paths when handling FILESEXTRAPATHS

Chris Larson kergoth at gmail.com
Thu Aug 25 00:20:05 UTC 2011


On Wed, Aug 24, 2011 at 5:16 PM, Paul Eggleton
<paul.eggleton at linux.intel.com> wrote:
> On Thursday 25 August 2011 00:16:40 Chris Larson wrote:
>> I strongly disagree with this. The fact is, we almost never go back
>> and "clean these up later", so crap accrues.
>
> We're talking about the difference between:
>
> if a = "":
>
> and
>
> if a:
>
> This is not crap, it's a triviality (for the case where the functional
> difference is not important anyway). If you care then by all means submit a
> patch to change it.

Yes, this example is trivial, but its just one of many instances of
this sort of code going in. I'd rather get the code clean to begin
with, rather than letting crap pile up and never do anything about it.
But I realize I care more about code quality than most of the people
in this project.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics




More information about the Openembedded-core mailing list