[OE-core] [PATCH] utils.bbclass: skip empty paths when handling FILESEXTRAPATHS

Chris Larson clarson at kergoth.com
Thu Aug 25 01:29:20 UTC 2011


On Wed, Aug 24, 2011 at 6:24 PM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Wed, 2011-08-24 at 17:20 -0700, Chris Larson wrote:
>> On Wed, Aug 24, 2011 at 5:16 PM, Paul Eggleton
>> <paul.eggleton at linux.intel.com> wrote:
>> > On Thursday 25 August 2011 00:16:40 Chris Larson wrote:
>> >> I strongly disagree with this. The fact is, we almost never go back
>> >> and "clean these up later", so crap accrues.
>> >
>> > We're talking about the difference between:
>> >
>> > if a = "":
>> >
>> > and
>> >
>> > if a:
>> >
>> > This is not crap, it's a triviality (for the case where the functional
>> > difference is not important anyway). If you care then by all means submit a
>> > patch to change it.
>>
>> Yes, this example is trivial, but its just one of many instances of
>> this sort of code going in. I'd rather get the code clean to begin
>> with, rather than letting crap pile up and never do anything about it.
>> But I realize I care more about code quality than most of the people
>> in this project.
>
> I'm not sure that is true, I think many people care about the code
> quality of OE. Quality means different things to different people. We
> also all have different priorities. It would be nice in many ways if our
> biggest worry was these sorts of issues but it isn't.

Biggest worry or not, I think choosing to push off things which are
trivial to improve now is a flawed approach in general, and is likely
to degrade quality over time. It's a question of philosophy and
approach. Choosing to do it as well as we can the first time versus
postponing it to a future time which may well never arrive. At this
point I can't say with any degree of confidence, personally, that our
overall quality is rising rather than lowering.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics




More information about the Openembedded-core mailing list