[OE-core] [PATCH 07/10] pango: add directfb DISTRO_FEATURE
Phil Blundell
philb at gnu.org
Wed Dec 7 10:27:22 UTC 2011
On Wed, 2011-12-07 at 16:58 +0800, Xiaofeng Yan wrote:
> +PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
> + ${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)}"
> +PACKAGECONFIG[x11] = "--with-x,--without-x,${X11DEPENDS}"
> +PACKAGECONFIG[directfb] = ",,directfb"
Hm, really? I didn't think pango had any inbuilt support for DirectFB.
Does this really accomplish anything?
> + [ ! -d "/etc/pango" ] && mkdir -p /etc/pango/
That will fail with a read-only rootfs, and I think it will also give an
error if /etc/pango already exists. It would be better to just ship
this directory in the package. (Also, it should be ${sysconfdir}.)
p.
More information about the Openembedded-core
mailing list