[OE-core] [PATCH 3/3] scripts/send-pull-request: allow sending of patches without a cover letter

Darren Hart dvhart at linux.intel.com
Fri Dec 9 19:45:49 UTC 2011


On 12/09/2011 11:36 AM, Otavio Salvador wrote:
> On Fri, Dec 9, 2011 at 17:34, Khem Raj <raj.khem at gmail.com
> <mailto:raj.khem at gmail.com>> wrote:
> 
>     why do you want to avoid cover letter ? or is it for other layers
>     other than oe-core
> 
> 
> When it is a single patch makes no sense to send a cover letter that
> most of time we just write the same of first commit.

Well, you could just use git-send-email when there is only 1 patch. I
had considered having the tool create only a single email if there was
only 1 patch. However, in the end, I just send the cover letter with the
pull requrest and let the single patch follow. It works fine and is
consistent with the other patches, even if it is a degenerate case.

So I don't think this is necessary really, but if it works for you and
doesn't get abused, I'm fine with it. Perhaps only allowing this if
there is indeed only 1 patch would be better.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel




More information about the Openembedded-core mailing list