[OE-core] [PATCH 5/9] Move check that all installed files are shipped into insane.bbclass
Dmitry Eremin-Solenikov
dbaryshkov at gmail.com
Tue Dec 13 16:52:35 UTC 2011
On 12/13/2011 08:27 PM, Phil Blundell wrote:
> On Tue, 2011-12-13 at 20:19 +0400, Dmitry Eremin-Solenikov wrote:
>> +def packages_qa_unshipped_files(d):
>> + skip = (d.getVar('INSANE_SKIP_${PN}', True) or "").split()
>> + if "unshipped" in skip:
>> + return False
Hmm. This really should be "return True". Should I send the fixed
version of this patch or this change will be picked by appliers?
>
> [...]
>
>> + if not packages_qa_unshipped_files(d):
>> + shipped_sane = False
>>
>> - if not walk_sane or not rdepends_sane:
>> + if not walk_sane or not rdepends_sane or not shipped_sane:
>> bb.fatal("QA run found fatal errors. Please consider fixing them.")
>
> Is that really what you want?
>
> p.
--
With best wishes
Dmitry
More information about the Openembedded-core
mailing list