[OE-core] [PATCH 9/9] libatomic-ops: drop directory with documentation to remove QA warning

Richard Purdie richard.purdie at linuxfoundation.org
Thu Dec 15 12:26:55 UTC 2011


On Wed, 2011-12-14 at 02:07 +0400, Dmitry Eremin-Solenikov wrote:
> On 12/13/2011 11:48 PM, Richard Purdie wrote:
> > On Tue, 2011-12-13 at 20:19 +0400, Dmitry Eremin-Solenikov wrote:
> >> Signed-off-by: Dmitry Eremin-Solenikov<dbaryshkov at gmail.com>
> >> ---
> >>   .../pulseaudio/libatomics-ops_1.2.bb               |    3 ++-
> >>   1 files changed, 2 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> >> index 184c167..f81aeb6 100644
> >> --- a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> >> +++ b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> >> @@ -26,5 +26,6 @@ ARM_INSTRUCTION_SET = "arm"
> >>   inherit autotools pkgconfig
> >>
> >>   do_install_append() {
> >> -	mv ${D}${datadir}/libatomic_ops ${D}${datadir}/libatomic-ops || true
> >> +	# those contain only docs, not necessary for now.
> >> +	rm -rf ${D}${datadir}/libatomic_ops || true
> >>   }
> >
> > Shouldn't we move that to docdir/${PN}?
> 
> I'm thinking another way: why is the recipe called libatomicS-ops (note 
> the S) if the upstream source is named as libatomc_ops (so it should 
> become libatomic-ops). Then documentation will land in the proper place 
> after the mv command which is currently in place.

I agree it should probably get renamed, I can't see a good reason for
that name. That will potentially cause some friction with other things
depending on it though :(

Cheers,

Richard





More information about the Openembedded-core mailing list