[OE-core] [yocto] [PATCH 5/9] task-core-boot: Allow DISTRO to disable keymaps

[Koen Kooi]

Op 21 dec. 2011, om 11:09 heeft Martin Jansa het volgende geschreven:

> On Wed, Dec 21, 2011 at 01:02:51AM -0800, Darren Hart wrote:
>> NOTE: I'm looking for a better way to do this.
>> 
>> keymaps pulls in gettext, which can't build without wide character support.
>> 
>> Rather than have to add a -tiny variant of every MACHINE to drop "keyboard" from
>> the MACHINE_FEATURES, just enable the DISTRO to define what gets added to
>> RDEPENDS_task-core-boot when MACHINE_FEATURES includes keyboard. By default,
>> keep "keymaps", but use DISTRO_KEYMAPS if it is set (to "" for example).
>> 
>> Signed-off-by: Darren Hart <dvhart at linux.intel.com>
>> ---
>> meta/recipes-core/tasks/task-core-boot.bb |    7 ++++++-
>> 1 files changed, 6 insertions(+), 1 deletions(-)
>> 
>> diff --git a/meta/recipes-core/tasks/task-core-boot.bb b/meta/recipes-core/tasks/task-core-boot.bb
>> index 05c280d..e097836 100644
>> --- a/meta/recipes-core/tasks/task-core-boot.bb
>> +++ b/meta/recipes-core/tasks/task-core-boot.bb
>> @@ -17,6 +17,11 @@ PR = "r9"
>> MACHINE_ESSENTIAL_EXTRA_RDEPENDS ?= ""
>> MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS ?= ""
>> 
>> +#
>> +# Set by the distro configuration to empty if not supported
>> +#
>> +DISTRO_KEYMAPS ?= "keymaps"
> 
> Why not VIRTUAL-RUNTIME_keymaps like everywhere else?

Why not just create a proper task for -tiny instead of making the already horrible task-core-boot even more horrible?

Besided that: this patch needs to go to the oe-core list

regards,

Koen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20111221/1e737c23/attachment-0002.sig>