[OE-core] [PATCH] insane bbclass: turn fatal errors back into fatal errors

[Richard Purdie]

So to further update on this, I think with the fixes I've merged,
OE-Core should be clean for all the QA tests except desktop file
warnings and ldflags.

ldflags was a problem as the code wasn't triggering at all in Yocto due
to a bug in bitbake to do with the way ??= vs ?= was being handled.

I'll have to run some further builds to see how bad the ldflags problem
is and it may take a little longer to address those issues but its a
step in the right direction at least and we can go ahead and make all
the other areas apart from desktop and ldflags become errors whenever we
want IMO.

Cheers,

Richard