[OE-core] [PATCH 1/2] qemu.inc: append to IMAGE_FSTYPES instead of weakly assigning them

[Koen Kooi]

Op 5 jul. 2011 om 15:17 heeft Richard Purdie <richard.purdie at linuxfoundation.org> het volgende geschreven:

> On Fri, 2011-07-01 at 08:50 +0200, Koen Kooi wrote:
>> Op 1 jul 2011, om 01:09 heeft Saul Wold het volgende geschreven:
>> 
>>> On 06/30/2011 03:33 PM, Koen Kooi wrote:
>>> I believe that this has been discussed elsewhere.
>> 
>> Let's post the outcome here then, since I still want this patch to go in.
>> 
>>>> Op 12 jun 2011, om 18:26 heeft Koen Kooi het volgende geschreven:
>>>> 
>>>>> The ext3 format is pretty much mandatory for qemu usage, so always create it.
>>>>> 
>>>>> Signed-off-by: Koen Kooi<koen at dominion.thruhere.net>
>>>>> ---
>>>>> meta/conf/machine/include/qemu.inc |    2 +-
>>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>> 
>>>>> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
>>>>> index 9ef242f..e908f69 100644
>>>>> --- a/meta/conf/machine/include/qemu.inc
>>>>> +++ b/meta/conf/machine/include/qemu.inc
>>>>> @@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/xserver ?= "xserver-kdrive"
>>>>> 
>>>>> MACHINE_FEATURES = "kernel26 apm alsa pcmcia bluetooth irda usbgadget screen"
>>>>> 
>>>>> -IMAGE_FSTYPES ?= "tar.bz2 ext3"
>>>>> +IMAGE_FSTYPES += "tar.bz2 ext3"
>>>>> 
>>>>> ROOT_FLASH_SIZE = "280"
>>>>> 
> 
> Well, I've mentioned this once in a reply but for the record if we start
> using += in machine files

+= is what we do in .dev fwiw

> this makes the values much harder to change
> and for anyone to exclude either tar.bz2 or ext3 from the variable.

how does the current exclusion work?


> 
> I'm therefore concerned this change makes things less usable.
> 
> Cheers,
> 
> Richard
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core