[OE-core] [PATCH 1/2] kernel-yocto: Fix case where recipe is always reparsed

Richard Purdie richard.purdie at linuxfoundation.org
Tue Jul 5 15:45:59 UTC 2011


If you include a bitbake variable as a comment in a shell function
then it gets expanded by the bitbake signature handling code.

This could be classed as a bug or a feature depending on your viewpoint
(e.g. a multiline variable included in a comment could actually contain
executable code).

Since we don't always want kernel-yocto to reparse this changes the
syntax of the comment so it doesn't trigger the problem.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 meta/classes/kernel-yocto.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 536434f..98272fc 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -136,7 +136,7 @@ do_validate_branches() {
  	 	return
  	fi
 
-	# nothing to do if SRCREV=${AUTOREV}
+	# nothing to do if SRCREV is AUTOREV
 	if [ "${SRCREV_machine}" = "AUTOINC" ]; then
 		# restore the branch for builds
 		git checkout -f ${KBRANCH}





More information about the Openembedded-core mailing list