[OE-core] [PATCH 1/2] kernel.bbclass: handle embedding of initramfs images

[Koen Kooi]

Op 8 jul. 2011 om 16:38 heeft Darren Hart <dvhart at linux.intel.com> het volgende geschreven:

> 
> 
> On 07/07/2011 04:11 PM, Andrea Adami wrote:
>> * from org.openembedded.dev (oe-classic)
> 
> Hi Andrea,
> 
> Please include a descriptive blurb about the patch. When people read
> through the commit log they need to know what problem this patch
> addresses and how it intends to go about it. If possible, it should also
> include the commit id from the source (I suspect that isn't an option here).
> 
> 
>> +INITRAMFS_IMAGE ?= ""
>> +INITRAMFS_TASK ?= ""
>> +
>> inherit kernel-arch deploy
>> 
>> PACKAGES_DYNAMIC += "kernel-module-*"
>> @@ -179,8 +191,18 @@ kernel_do_configure() {
>>        cp "${WORKDIR}/defconfig" "${S}/.config"
>>    fi
>>         yes '' | oe_runmake oldconfig
>> +
>> +    if [ ! -z "${INITRAMFS_IMAGE}" ]; then
>> +        for img in cpio.gz cpio.lzo cpio.lzma; do
>> +        if [ -e "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE}-${MACHINE}.$img"
>> +            cp "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE}-${MACHINE}.$i
>> +        fi
>> +        done
>> +    fi
> 
> 
> Hrm... Why is this part of do_configure? Seems a lot more like a deploy
> or install step. Also, the cp line has been truncated here.

the initramfs gets embedded into the kernel, so it needs to happen before do-compile. maybe a seperate task is better



> 
> -- 
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core