[OE-core] [PATCH] Add support for BAD_RECOMMENDATIONS to rootfs_ipk
Phil Blundell
pb at pbcl.net
Mon Jul 11 09:00:18 UTC 2011
On Mon, 2011-07-11 at 09:53 +0100, Chris Elston wrote:
> + STATUS=${IMAGE_ROOTFS}${opkglibdir}/status
> + mkdir -p `dirname ${STATUS}`
Not that it's a massive deal, but this call to "dirname" is redundant
since dirname ${STATUS} is ${IMAGE_ROOTFS}${opkglibdir} by definition.
> + # prime the status file with bits that we don't want
> + for i in ${BAD_RECOMMENDATIONS}; do
> + infln="`opkg-cl ${IPKG_ARGS} info $i | grep -e
> '^Package:' -e '^Architecture:' -e '^Version:'`"
> + if [ ! -z "$infln" ]; then
> + echo "$infln" >> $STATUS
Reading this again I wonder what would happen if one of the packages
named in BAD_RECOMMENDATIONS doesn't actually exist. Can you verify
that this code does something sensible in that case?
p.
More information about the Openembedded-core
mailing list