[OE-core] [PATCH 1/2] strace: Define own sigmask macro if not defined already in signal.h
Phil Blundell
pb at pbcl.net
Wed Jul 13 09:48:52 UTC 2011
On Tue, 2011-07-12 at 21:19 -0700, Khem Raj wrote:
> ++#ifndef sigmask
> ++/* Compute mask for signal SIG. */
> ++#define sigmask(sig) __sigmask(sig)
> ++#endif /* sigmask */
That looks a bit dubious to me. If this is relying on some uclibc
implementation detail then I think it should either be applied for
uclibc only, or guarded with something like "#if defined(__UCLIBC__)
&& !defined(sigmask)". Otherwise you might end up trying to call
__sigmask() on non-uclibc systems which could have unwanted effects.
p.
More information about the Openembedded-core
mailing list