[OE-core] [PATCH 46/50] mesa-xlib: Dont use locales with uclibc

Khem Raj raj.khem at gmail.com
Wed Jul 20 18:07:56 UTC 2011


On 07/20/2011 03:14 AM, Phil Blundell wrote:
> On Wed, 2011-07-20 at 01:28 -0700, Saul Wold wrote:
>> +We disable locale on uclibc in OE therefore we do not use it if building for uclibc
>> +
>> +Signed-off-by: Khem Raj<raj.khem at gmail.com>
>> +Upstream-Status: Inappropriate<OE config related>
>> +
>> + {
>> +-#if defined(_GNU_SOURCE)&&  !defined(__CYGWIN__)&&  !defined(__FreeBSD__)
>> ++#if defined(_GNU_SOURCE)&&  !defined(__CYGWIN__)&&  !defined(__FreeBSD__)&&  !defined(__UCLIBC__)
>
> I'm not totally thrilled about having the equivalence between "uclibc"
> and "no locale" patched into random sources in a piecemeal way like
> this.  uClibc doesn't inherently lack locale support, it's just that the
> default oe-core configuration happens to turn it off, and there's no
> reason that another layer mightn't decide to enable it again.  It would
> suck if that layer then had to re-patch all these recipes to take the
> __UCLIBC__ conditional back out.
>
> I think it would be better to replace this sort of thing with an
> autoconf linker test that checks to see whether newlocale() is actually
> available in the installed libc.
>

Well I thought so. Its just lazyness and time :)
I will rework it that way as I did it for other recipe

> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core





More information about the Openembedded-core mailing list