[OE-core] [PATCH 5/5] package.bbclass: fixup_perms - symlink bug fix

Phil Blundell philb at gnu.org
Mon Jul 25 14:05:46 UTC 2011


On Mon, 2011-07-25 at 14:47 +0100, Richard Purdie wrote:
> From: Mark Hatle <mark.hatle at windriver.com>
> 
> We don't want to change the owner/mode of symlinks, as this may
> affect the target of the link.  Also broken links will fail as well.

This seems like it will cause links themselves to end up getting shipped
under the UID/GID that was used for building, which was the whole thing
that fixup_perms was trying to avoid in the first place.  Surely you do
want to fix their ownership, it's just the mode that you oughtn't to be
trying to change.

Also, unrelated to the technical details, the subject line of this patch
is not especially illuminating.  It would be better to say something
like "package.bbclass: don't change mode/owner of symlinks" rather than
like "symlink bug fix".

p.






More information about the Openembedded-core mailing list